Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable MacOS flakies Citadel #1545

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Disable MacOS flakies Citadel #1545

merged 7 commits into from
Jun 23, 2022

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Jun 20, 2022 •
edited
Loading

Backport of #1398 to Citadel and temporary disabled tests for #630 #154

Summary

Disabling flaky tests on MacOS to help with gazebo-tooling/release-tools#398

Checklist

  • Signed all commits for DCO
  • Added tests -> actually disabling tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@Blast545 Blast545 requested a review from chapulina as a code owner June 20, 2022 17:43
@Blast545 Blast545 self-assigned this Jun 20, 2022
@Blast545 Blast545 added macOS macOS support tests Broken or missing tests / testing infra labels Jun 20, 2022
@chapulina
Copy link
Contributor

I'll leave a cross-link to #807, which I believe intended to fix these tests. CC @azeey

@Blast545
Fix linter
3c119a3 
Signed-off-by: Jorge Perez <[email protected]>
@Blast545
Include extra macros
77dc77b 
Signed-off-by: Jorge Perez <[email protected]>
@Blast545
Add extra macro
b7910c5 
Signed-off-by: Jorge Perez <[email protected]>
@Blast545
Use macro as in Citadel
58514b6 
Signed-off-by: Jorge Perez <[email protected]>
@codecov
Copy link

codecov bot commented Jun 20, 2022 •
edited
Loading

Codecov Report

Merging #1545 (58514b6) into ign-gazebo3 (dc5f117) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo3    #1545   +/-   ##
============================================
  Coverage        77.76%   77.76%           
============================================
  Files              250      250           
  Lines            14443    14443           
============================================
  Hits             11231    11231           
  Misses            3212     3212

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc5f117...58514b6. Read the comment docs.

@chapulina chapulina added the 🏰 citadel Ignition Citadel label Jun 20, 2022
@Blast545
Copy link
Contributor Author

All tests passing, want to review and merge? :D @chapulina

Besides the remaining protobuf warnings, I think Citadel is all covered to enable CI checks. I'll move further with Fortress now.

chapulina
chapulina approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Blast545 , let's give this a try for a few weeks and see if other flakies come up.

@chapulina chapulina merged commit abe0ff6 into ign-gazebo3 Jun 23, 2022
@chapulina chapulina deleted the blast545/disable_homebrew_flakies_citadel branch June 23, 2022 19:19
scpeters added a commit that referenced this pull request Jul 19, 2022
@scpeters
Merge #1545 forward to ign-gazebo6
54ad6e2 
Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@Blast545 Blast545

Labels
🏰 citadel Ignition Citadel macOS macOS support tests Broken or missing tests / testing infra
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blast545 @chapulina @azeey